chittshota commented on issue #1414: HDFS-14835. RBF: Secured Router should not run when it can't initialize DelegationTokenSecretManager URL: https://github.com/apache/hadoop/pull/1414#issuecomment-530058890 @tasanuma That's a good point. I was checking namenode to see if it does throw any exceptions if secret manager could not be successfully initialized. Namenode DOES fail if secret manager is not initialized correctly so yes then router failing should be fine. ``` private void startSecretManager() { if (dtSecretManager != null) { try { dtSecretManager.startThreads(); } catch (IOException e) { // Inability to start secret manager // can't be recovered from. throw new RuntimeException(e); } } } ``` LGTM. +1
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
