goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r323564000
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestNoHaRMFailoverProxyProvider.java ########## @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.yarn.client; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.io.retry.FailoverProxyProvider; +import org.apache.hadoop.yarn.api.ApplicationClientProtocol; +import org.apache.hadoop.yarn.api.records.NodeReport; +import org.apache.hadoop.yarn.client.api.YarnClient; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.apache.hadoop.yarn.exceptions.YarnException; +import org.apache.hadoop.yarn.server.MiniYARNCluster; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.Proxy; +import java.net.InetSocketAddress; +import java.util.List; +import java.util.Random; + +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.eq; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +public class TestNoHaRMFailoverProxyProvider { + private final int NODE_MANAGER_COUNT = 1; + private Configuration conf; + + @Before + public void setUp() throws IOException, YarnException { + conf = new YarnConfiguration(); + } + + @Test + public void testRestartedRM() throws Exception { + MiniYARNCluster cluster = + new MiniYARNCluster( + "testRestartedRMNegative", NODE_MANAGER_COUNT, 1, 1); + YarnClient rmClient = YarnClient.createYarnClient(); + try { + cluster.init(conf); + cluster.start(); + final Configuration yarnConf = cluster.getConfig(); + rmClient = YarnClient.createYarnClient(); + rmClient.init(yarnConf); + rmClient.start(); + List<NodeReport> nodeReports = rmClient.getNodeReports(); + Assert.assertEquals( + "The proxy didn't get expected number of node reports", + NODE_MANAGER_COUNT, nodeReports.size()); + } finally { + if (rmClient != null) { + rmClient.stop(); + } + cluster.stop(); + } + } + + /** + * Tests the proxy generated by {@link AutoRefreshNoHARMFailoverProxyProvider} + * will connect to RM. + */ + @Test + public void testConnectingToRM() throws Exception { + conf.set(YarnConfiguration.CLIENT_FAILOVER_NO_HA_PROXY_PROVIDER, + AutoRefreshNoHARMFailoverProxyProvider.class.getName()); + + MiniYARNCluster cluster = + new MiniYARNCluster( + "testRestartedRMNegative", NODE_MANAGER_COUNT, 1, 1); + YarnClient rmClient = null; + try { + cluster.init(conf); + cluster.start(); + final Configuration yarnConf = cluster.getConfig(); + rmClient = YarnClient.createYarnClient(); + rmClient.init(yarnConf); + rmClient.start(); + List<NodeReport> nodeReports = rmClient.getNodeReports(); + Assert.assertEquals( + "The proxy didn't get expected number of node reports", + NODE_MANAGER_COUNT, nodeReports.size()); + } finally { + if (rmClient != null) { + rmClient.stop(); + } + cluster.stop(); + } + } + + @Test + public void testDefaultFPPGetOneProxy() throws Exception { + class TestProxy extends Proxy implements Closeable { + protected TestProxy(InvocationHandler h) { + super(h); + } + + @Override + public void close() throws IOException { + } + } + + // Create two proxies and mock a RMProxy + Proxy mockProxy1 = new TestProxy((proxy, method, args) -> null); + Class protocol = ApplicationClientProtocol.class; + RMProxy mockRMProxy = mock(RMProxy.class); + DefaultNoHARMFailoverProxyProvider<RMProxy> fpp = + new DefaultNoHARMFailoverProxyProvider<RMProxy>(); + + Random rand = new Random(); + int port1 = rand.nextInt(65535); + + InetSocketAddress mockAdd1 = new InetSocketAddress(port1); + + // Mock RMProxy methods + when(mockRMProxy.getRMAddress(any(YarnConfiguration.class), + any(Class.class))).thenReturn(mockAdd1); + when(mockRMProxy.getProxy(any(YarnConfiguration.class), + any(Class.class), eq(mockAdd1))).thenReturn(mockProxy1); + + // Initialize failover proxy provider and get proxy from it. + fpp.init(conf, mockRMProxy, protocol); + FailoverProxyProvider.ProxyInfo<RMProxy> actualProxy1 = fpp.getProxy(); + Assert.assertEquals( + "AutoFefreshRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + + // Invoke fpp.getProxy() multiple times and + // validate the returned proxy is always mockProxy1 + actualProxy1 = fpp.getProxy(); + Assert.assertEquals( + "AutoFefreshRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + actualProxy1 = fpp.getProxy(); + Assert.assertEquals( + "AutoFefreshRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + + // verify that mockRMProxy.getProxy() is invoked once only. + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd1)); + + // Perform Failover and get proxy again from failover proxy provider + fpp.performFailover(actualProxy1.proxy); + FailoverProxyProvider.ProxyInfo<RMProxy> actualProxy2 = fpp.getProxy(); + Assert.assertEquals("AutoFefreshRMFailoverProxyProvider " + + "doesn't generate expected proxy after failover", + mockProxy1, actualProxy2.proxy); + + // verify that mockRMProxy.getProxy() didn't get invoked again after + // performFailover() + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd1)); + } + + /** + * Test that the {@link AutoRefreshNoHARMFailoverProxyProvider} + * will generate different proxies after RM IP changed + * and {@link AutoRefreshNoHARMFailoverProxyProvider#performFailover(Object)} + * get called. + */ + @Test + public void testAutoRefreshIPChange() throws Exception { + conf.set(YarnConfiguration.CLIENT_FAILOVER_NO_HA_PROXY_PROVIDER, Review comment: I think we can potentially use setClass() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
