steveloughran commented on issue #1208: HADOOP-16423. S3Guard fsck: Check 
metadata consistency between S3 and metadatastore (log)
URL: https://github.com/apache/hadoop/pull/1208#issuecomment-530748126
 
 
   # +1
   
   As well as all the automated tests, did some manual command line operations.
   * empty args
   * command without -check
   * -check without path
   * against store marked as auth but with incomplete MS
   * after doing an import, same store
   * empty store
   * unguarded store
   
   All outcomes were as expected 
   
   I'm happy with this 
   
   ## Followup
   
   One of the changes with the HADOOP-16430 PR is that we now have an S3A FS 
method `boolean allowAuthoritative(final Path path) ` that takes a path and 
returns true iff its authoritative either by the MS being auth *or* the given 
path being marked as one of the authoritative dirs. I think the validation when 
an authoritative directory is consistent between the metastore and S3 should be 
using this when it wants to highlight an authoritative path is inconsistent. 
   
   This can be a follow-on patch, because as usual it will need more tests, in 
the code, and someone to try out the command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to