[
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928784#comment-16928784
]
stack commented on HADOOP-13363:
--------------------------------
On your #1 and #2 choices above, #1 works for us. Cost is negligible (caveat
initial setup). The separate repo is forgotten till comes time to spin up new
release. On #2, the submodule would be hard to 'explain' being in-line w/
hadoop checkout and there is too much stuff in hadoop repo as it is.
Would suggest you broaden the scope of #1 so as to include other finicky
dependencies beyond protobuf that might benefit being hidden from
downstreamers. Could be done in another issue but suggest be careful you don't
fence off the possibility (perhaps hadoop-thirdparty rather than
hadoop-shaded-thirdparty as repo name?).
bq. Release process: can it be issued by the ASF?
Why not? Would suggest it an artifact treated as any other shipped by this PMC.
You'd generate an RC and vote on it (This is how hbase PMC does it).
bq. There are many javac warnings due to new protobuf-3.6.1 dependency due to
deprecated APIs usage.
Isn't there a flag to turn these off (IIRC).
> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
> Key: HADOOP-13363
> URL: https://issues.apache.org/jira/browse/HADOOP-13363
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Allen Wittenauer
> Assignee: Vinayakumar B
> Priority: Major
> Labels: security
> Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch,
> HADOOP-13363.003.patch, HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms. (See, for
> example, https://gist.github.com/BennettSmith/7111094 ). In order for us to
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is
> starting to slowly disappear as a standard install-able package for even
> Linux/x86, we need to either upgrade or self bundle or something else.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
