[
https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087508#comment-13087508
]
Uma Maheswara Rao G commented on HADOOP-7552:
---------------------------------------------
Hi Eli,
I have verified this patch. Looks no issue.
I have one very small nit.
I think, in TestNativeIO also we can remove throws class.
{code}
@Before
public void setupTestDir() throws IOException {
FileUtil.fullyDelete(TEST_DIR);
TEST_DIR.mkdirs();
}
{code}
There are some instances in HDFS also like this, but we can handle them
separately may be. Since this is testcode, you can decide based on priority.
Other than this patch looks good!
+1 from my side.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have
> IOException in its throws clause. Having it listed makes it easy to think
> you'll get an IOException eg trying to delete a non-existant file or on an IO
> error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
