elek commented on a change in pull request #1277: HDDS-1054. List Multipart
uploads in a bucket
URL: https://github.com/apache/hadoop/pull/1277#discussion_r324409675
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1270,6 +1271,58 @@ public void abortMultipartUpload(OmKeyArgs omKeyArgs)
throws IOException {
}
+ @Override
+ public OmMultipartUploadList listMultipartUploads(String volumeName,
+ String bucketName, String prefix) throws OMException {
+ Preconditions.checkNotNull(volumeName);
+ Preconditions.checkNotNull(bucketName);
+
+ metadataManager.getLock().acquireLock(BUCKET_LOCK, volumeName, bucketName);
+ try {
+
+ List<String> multipartUploadKeys =
+ metadataManager
+ .getMultipartUploadKeys(volumeName, bucketName, prefix);
+
+ List<OmMultipartUpload> collect = multipartUploadKeys.stream()
+ .map(OmMultipartUpload::from)
+ .map(upload -> {
+ String dbKey = metadataManager
+ .getOzoneKey(upload.getVolumeName(),
+ upload.getBucketName(),
+ upload.getKeyName());
+ try {
+ Table<String, OmKeyInfo> openKeyTable =
+ metadataManager.getOpenKeyTable();
+
+ OmKeyInfo omKeyInfo =
+ openKeyTable.get(upload.getDbKey());
Review comment:
You are 100% right. But it seems to be a bigger change. Let's do it in
https://issues.apache.org/jira/browse/HDDS-2131
(On the other hand I added audit + metrics support because they were just a
few lines)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
