steveloughran commented on a change in pull request #970: HADOOP-16371: Option
to disable GCM for SSL connections when running on Java 8
URL: https://github.com/apache/hadoop/pull/970#discussion_r324641274
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractSeek.java
##########
@@ -75,18 +83,23 @@
@Parameterized.Parameters
public static Collection<Object[]> params() {
return Arrays.asList(new Object[][]{
- {INPUT_FADV_RANDOM},
- {INPUT_FADV_NORMAL},
- {INPUT_FADV_SEQUENTIAL},
+ {INPUT_FADV_RANDOM, Default_JSSE},
Review comment:
While it's good to see this coverage, we do now have a test which is taking
4 min, and I'm trying to keep execution time of a non-scale test with a runner
pool of 12 down to < 20 mins -this isn't going to help.
I propose only having the random and normal as the seek policies for the GCM
tests; and remove these from the default jsse. Yes, it's a simpler matrix but
as the default_jsse option gets implicitly tested everywhere,we aren't losing
coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
