vinayakumarb commented on issue #1432: HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1 URL: https://github.com/apache/hadoop/pull/1432#issuecomment-531755823 1. > -1 javac 955 root generated 396 new + 1466 unchanged - 0 fixed = 1862 total (was 1466) All new Javac errors are due to either Generated proto classes are proto dependency itself. Deprecations in src files are handled (in next commit). Javac warnings inside generated classes can be ignored or (can be excluded directy from count? ) 2. Shaded client errors are due to not-using "-Ptest-patch" in the mvn command used to verify the shaded client errors. Used locally and found no errors. > mvn --batch-mode -Ptest-patch -Pparallel-tests -P!shelltest -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind -Drequire.test.libhadoop -Pyarn-ui clean test -fae > > [INFO] ------------------------------------------------------- > [INFO] T E S T S > [INFO] ------------------------------------------------------- > [INFO] Running org.apache.hadoop.example.ITUseMiniCluster > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.563 s - in org.apache.hadoop.example.ITUseMiniCluster > [INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > [INFO] 3. Test "TestLargeBlockReport.testBlockReportExceedsLengthLimit" is related. CodedInputStream's default limit is hardcoded to 2GB from 64MB in 2.5.0. So now excecption thrown before start reading the RPC request itself. All other tests are unrelated to this changes. Verified locally, fails in both trunk as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
