steveloughran commented on issue #568: HADOOP-15691 Add PathCapabilities to FS and FC to complement StreamCapabilities URL: https://github.com/apache/hadoop/pull/568#issuecomment-532696623 all checksums are legit, will fix ``` ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java:30:import java.util.Locale;:8: Unused import - java.util.Locale. [UnusedImports] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java:50:import org.apache.hadoop.fs.impl.PathCapabilitiesSupport;:8: Unused import - org.apache.hadoop.fs.impl.PathCapabilitiesSupport. [UnusedImports] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FsLinkResolution.java:76: T apply(final AbstractFileSystem fs, final Path path):13: Redundant 'final' modifier. [RedundantModifier] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FsLinkResolution.java:76: T apply(final AbstractFileSystem fs, final Path path):42: Redundant 'final' modifier. [RedundantModifier] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/PathCapabilitiesSupport.java:30:@InterfaceAudience.Private: Missing a Javadoc comment. [JavadocType] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/PathCapabilitiesSupport.java:30:@InterfaceAudience.Private:1: Utility classes should not have a public or default constructor. [HideUtilityClassConstructor] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java:34:import org.apache.hadoop.fs.CommonPathCapabilities;:8: Unused import - org.apache.hadoop.fs.CommonPathCapabilities. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java:125:import static org.apache.hadoop.fs.impl.PathCapabilitiesSupport.validatePathCapabilityArgs;:15: Unused import - org.apache.hadoop.fs.impl.PathCapabilitiesSupport.validatePathCapabilityArgs. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/DfsPathCapabilities.java:29:public final class DfsPathCapabilities {: Missing a Javadoc comment. [JavadocType] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:49:import java.util.Locale;:8: Unused import - java.util.Locale. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:66:import org.apache.hadoop.fs.CommonPathCapabilities;:8: Unused import - org.apache.hadoop.fs.CommonPathCapabilities. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:80:import org.apache.hadoop.fs.PathCapabilities;:8: Unused import - org.apache.hadoop.fs.PathCapabilities. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:140:import static org.apache.hadoop.fs.impl.PathCapabilitiesSupport.validatePathCapabilityArgs;:15: Unused import - org.apache.hadoop.fs.impl.PathCapabilitiesSupport.validatePathCapabilityArgs. [UnusedImports] ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java:89:import java.util.Locale;:8: Unused import - java.util.Locale. [UnusedImports] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/select/SelectConstants.java:53: public static final String S3_SELECT_CAPABILITY = "fs.s3a.capability.select.sql";: Line is longer than 80 characters (found 83). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java:29:import org.junit.Assume;:8: Unused import - org.junit.Assume. [UnusedImports] ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
