timmylicheng commented on a change in pull request #1431: HDDS-1569 Support
creating multiple pipelines with same datanode
URL: https://github.com/apache/hadoop/pull/1431#discussion_r326457028
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
##########
@@ -80,7 +81,17 @@ public PipelinePlacementPolicy(
*/
@VisibleForTesting
boolean meetCriteria(DatanodeDetails datanodeDetails, long heavyNodeLimit) {
- return (nodeManager.getPipelinesCount(datanodeDetails) <= heavyNodeLimit);
+ if (heavyNodeLimit == 0) {
+ // no limit applied.
+ return true;
+ }
+ boolean meet = (nodeManager.getPipelinesCount(datanodeDetails)
+ <= heavyNodeLimit);
+ if (!meet) {
+ LOG.error("Pipeline Placement: Doesn't meet the criteria to be viable " +
Review comment:
> log level "info" instead of "error".
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
