mukund-thakur commented on a change in pull request #1404: HDFS-13660 Copy file
till the source file length during distcp
URL: https://github.com/apache/hadoop/pull/1404#discussion_r326535133
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyMapper.java
##########
@@ -444,6 +450,57 @@ private void testCopyingExistingFiles(FileSystem fs,
CopyMapper copyMapper,
}
}
+ @Test(timeout = 40000)
+ public void testCopyWhileAppend() throws Exception {
+ deleteState();
+ mkdirs(SOURCE_PATH + "/1");
+ touchFile(SOURCE_PATH + "/1/3");
+ CopyMapper copyMapper = new CopyMapper();
+ StubContext stubContext = new StubContext(getConfiguration(), null, 0);
+ Mapper<Text, CopyListingFileStatus, Text, Text>.Context context =
+ stubContext.getContext();
+ copyMapper.setup(context);
+ final Path path = new Path(SOURCE_PATH + "/1/3");
+ int manyBytes = 100000000;
+ appendFile(path, manyBytes);
+ ScheduledExecutorService scheduledExecutorService =
+ Executors.newSingleThreadScheduledExecutor();
+ Runnable task = new Runnable() {
+ public void run() {
+ try {
+ int maxAppendAttempts = 20;
+ int appendCount = 0;
+ while (appendCount < maxAppendAttempts) {
+ appendFile(path, 1000);
+ Thread.sleep(200);
+ appendCount++;
+ }
+ } catch (IOException | InterruptedException e) {
+ LOG.error("Exception encountered ", e);
+ Assert.fail("Test failed: " + e.getMessage());
Review comment:
Okay. I will make the change then.
@steveloughran Do you want me to fix the current 3 checkstyle issues? You
said we can ignore some for better readability of code while doing parallel
reviews.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
