steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow
separate custom signing algorithms for S3 and DDB
URL: https://github.com/apache/hadoop/pull/1332#discussion_r326731189
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -343,9 +343,43 @@ private Constants() {
public static final String SERVER_SIDE_ENCRYPTION_KEY =
"fs.s3a.server-side-encryption.key";
- //override signature algorithm used for signing requests
+ /**
+ * List of custom Signers. The signer class will be loaded, and the signer
+ * name will be associated with this signer class in the S3 SDK. e.g. Single
+ * CustomSigner -> 'CustomSigner:org.apache...CustomSignerClass Multiple
+ * CustomSigners ->
'CSigner1:CustomSignerClass1,CSigner2:CustomerSignerClass2
+ */
+ public static final String CUSTOM_SIGNERS = "fs.s3a.custom.signers";
+
+ /**
+ * There's 3 parameters that can be used to specify a non-default signing
+ * algorithm. fs.s3a.signing-algorithm - This property has existed for the
+ * longest time. If specified, without either of the other 2 properties being
+ * specified, this signing algorithm will be used for S3 and DDB (S3Guard).
+ * The other 2 properties override this value for S3 or DDB.
Review comment:
also: other uses like STS. Maybe say "non S3 requests, such as to DDB (for
S3Guard) or to STS."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
