ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326765094
########## File path: hadoop-tools/hadoop-fs2img/src/main/java/org/apache/hadoop/hdfs/server/namenode/TreePath.java ########## @@ -159,13 +180,17 @@ INode toFile(UGIResolver ugi, BlockResolver blk, INode toDirectory(UGIResolver ugi) { final FileStatus s = getFileStatus(); - ugi.addUser(s.getOwner()); - ugi.addGroup(s.getGroup()); + final AclStatus aclStatus = getAclStatus(); + long permissions = ugi.getPermissionsProto(s, aclStatus); INodeDirectory.Builder b = INodeDirectory.newBuilder() .setModificationTime(s.getModificationTime()) .setNsQuota(DEFAULT_NAMESPACE_QUOTA) .setDsQuota(DEFAULT_STORAGE_SPACE_QUOTA) - .setPermission(ugi.resolve(s)); + .setPermission(permissions); + if (aclStatus != null) { + throw new UnsupportedOperationException( Review comment: Yes. I am proposing to fix the scanner in the PR which is independent of the `ImageWriter`. The consumer of the scanner can choose to ignore the ACL. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org