goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r326824345
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailoverProxyProvider.java ########## @@ -0,0 +1,320 @@ + + +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.client; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.io.retry.FailoverProxyProvider; +import org.apache.hadoop.yarn.api.ApplicationClientProtocol; +import org.apache.hadoop.yarn.client.api.YarnClient; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.apache.hadoop.yarn.exceptions.YarnException; +import org.junit.Before; +import org.junit.Test; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.Proxy; +import java.net.InetSocketAddress; + +import static org.junit.Assert.*; +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.eq; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +/** + * Unit tests for {@link ConfiguredRMFailoverProxyProvider} and + * {@link AutoRefreshRMFailoverProxyProvider}. + */ +public class TestRMFailoverProxyProvider { + private Configuration conf; + + @Before + public void setUp() throws IOException, YarnException { + conf = new YarnConfiguration(); + conf.setClass(YarnConfiguration.CLIENT_FAILOVER_NO_HA_PROXY_PROVIDER, + ConfiguredRMFailoverProxyProvider.class, RMFailoverProxyProvider.class); + conf.setBoolean(YarnConfiguration.RM_HA_ENABLED, true); + } + + /** + * Test that the {@link ConfiguredRMFailoverProxyProvider} + * will loop through its set of proxies when + * and {@link ConfiguredRMFailoverProxyProvider#performFailover(Object)} + * gets called. + */ + @Test + public void testFailoverChange() throws Exception { + class MockProxy extends Proxy implements Closeable { + protected MockProxy(InvocationHandler h) { + super(h); + } + + @Override + public void close() throws IOException { + } + } + + //Adjusting the YARN Conf + conf.set(YarnConfiguration.RM_HA_IDS, "rm0, rm1"); + + // Create two proxies and mock a RMProxy + Proxy mockProxy2 = new MockProxy((proxy, method, args) -> null); + Proxy mockProxy1 = new MockProxy((proxy, method, args) -> null); + + Class protocol = ApplicationClientProtocol.class; + RMProxy mockRMProxy = mock(RMProxy.class); + ConfiguredRMFailoverProxyProvider <RMProxy> fpp = + new ConfiguredRMFailoverProxyProvider <RMProxy> (); + + // generate two address with different ports. + // Default port of yarn RM + int port1 = 8032; + int port2 = 8031; + InetSocketAddress mockAdd1 = new InetSocketAddress(port1); + InetSocketAddress mockAdd2 = new InetSocketAddress(port2); + + // Mock RMProxy methods + when(mockRMProxy.getRMAddress(any(YarnConfiguration.class), + any(Class.class))).thenReturn(mockAdd1); + when(mockRMProxy.getProxy(any(YarnConfiguration.class), + any(Class.class), eq(mockAdd1))).thenReturn(mockProxy1); + + // Initialize failover proxy provider and get proxy from it. + fpp.init(conf, mockRMProxy, protocol); + FailoverProxyProvider.ProxyInfo <RMProxy> actualProxy1 = fpp.getProxy(); + assertEquals( + "ConfiguredRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + + // Invoke fpp.getProxy() multiple times and + // validate the returned proxy is always mockProxy1 + actualProxy1 = fpp.getProxy(); + assertEquals( + "ConfiguredRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + actualProxy1 = fpp.getProxy(); + assertEquals( + "ConfiguredRMFailoverProxyProvider doesn't generate " + + "expected proxy", + mockProxy1, actualProxy1.proxy); + + // verify that mockRMProxy.getProxy() is invoked once only. + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd1)); + + // Mock RMProxy methods to generate different proxy + // based on different IP address. + when(mockRMProxy.getRMAddress( + any(YarnConfiguration.class), + any(Class.class))).thenReturn(mockAdd2); + when(mockRMProxy.getProxy( + any(YarnConfiguration.class), + any(Class.class), eq(mockAdd2))).thenReturn(mockProxy2); + + // Perform Failover and get proxy again from failover proxy provider + fpp.performFailover(actualProxy1.proxy); + FailoverProxyProvider.ProxyInfo <RMProxy> actualProxy2 = fpp.getProxy(); + assertEquals("ConfiguredRMFailoverProxyProvider " + + "doesn't generate expected proxy after failover", + mockProxy2, actualProxy2.proxy); + + // check the proxy is different with the one we created before. + assertNotEquals("ConfiguredRMFailoverProxyProvider " + + "shouldn't generate same proxy after failover", + actualProxy1.proxy, actualProxy2.proxy); + + // verify that mockRMProxy.getProxy() has been one with each address + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd1)); + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd2)); + + // Mock RMProxy methods to generate the first proxy again + when(mockRMProxy.getRMAddress( + any(YarnConfiguration.class), + any(Class.class))).thenReturn(mockAdd1); + when(mockRMProxy.getProxy( + any(YarnConfiguration.class), + any(Class.class), eq(mockAdd1))).thenReturn(mockProxy1); + + // Perform Failover and get proxy again from failover proxy provider + fpp.performFailover(actualProxy2.proxy); + FailoverProxyProvider.ProxyInfo <RMProxy> actualProxy3 = fpp.getProxy(); + + // check the proxy is the same as the one we created before. + assertEquals("ConfiguredRMFailoverProxyProvider " + + "doesn't generate expected proxy after failover", + mockProxy1, actualProxy3.proxy); + + // verify that mockRMProxy.getProxy() has still only been invoked twice + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd1)); + verify(mockRMProxy, times(1)) + .getProxy(any(YarnConfiguration.class), any(Class.class), + eq(mockAdd2)); + } + + /** + * Test that the {@link AutoRefreshRMFailoverProxyProvider} + * will loop through its set of proxies when + * and {@link AutoRefreshRMFailoverProxyProvider#performFailover(Object)} + * gets called. + */ + @Test + public void testAutoRefreshFailoverChange() throws Exception { + conf.setClass(YarnConfiguration.CLIENT_FAILOVER_NO_HA_PROXY_PROVIDER, + AutoRefreshRMFailoverProxyProvider.class, + RMFailoverProxyProvider.class); + + class MockProxy extends Proxy implements Closeable { Review comment: You may want to do this MockProxy used by the other methods instead of repeating. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
