[
https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935388#comment-16935388
]
Vinayakumar B edited comment on HADOOP-16559 at 9/22/19 6:49 PM:
-----------------------------------------------------------------
{quote}And here, since this is not a trivial change, I suggest we revert
HADOOP-16557 first? Now it is a pain for developpers as we need protobuf 3.7.1
to compile trunk and then 2.5.0 to compile other branches...
{quote}
Need not switch back and forth to build separate branches. protobuf 3.7.1 can
be installed in a separate location (ex: /opt/protobuf-3.7.1) and "protoc.path"
system property pointing to absolute path of 3.7.1 protoc (ex:
-Dprotoc.path=/opt/protobuf-3.7.1/bin/protoc) can be used to build trunk until
we replace protobuf-maven-plugin.
Instead of compiling protobuf from source (which is a very time consuming
task), can download the applicable exe from maven central
[here|https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.7.1/]
directly and provide as "protoc.path". Make sure it exe have executable
permissions.
was (Author: vinayrpet):
{quote}And here, since this is not a trivial change, I suggest we revert
HADOOP-16557 first? Now it is a pain for developpers as we need protobuf 3.7.1
to compile trunk and then 2.5.0 to compile other branches...
{quote}
Need not switch back and forth to build separate branches. protobuf 3.7.1 can
be installed in a separate location (ex: /opt/protobuf-3.7.1) and "protoc.path"
system property pointing to absolute path of 3.7.1 protoc (ex:
-Dprotoc.path=/opt/protobuf-3.7.1/bin/protoc) can be used to build trunk until
we replace protobuf-maven-plugin.
> [HDFS] use protobuf-maven-plugin to generate protobuf classes
> -------------------------------------------------------------
>
> Key: HADOOP-16559
> URL: https://issues.apache.org/jira/browse/HADOOP-16559
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Vinayakumar B
> Priority: Major
>
> Use "protoc-maven-plugin" to dynamically download protobuf executable to
> generate protobuf classes from proto file
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
