vinayakumarb commented on a change in pull request #1496: HADOOP-16560. [YARN +
MAPREDUCE] use protobuf-maven-plugin to generat…
URL: https://github.com/apache/hadoop/pull/1496#discussion_r326914640
##########
File path: hadoop-project/pom.xml
##########
@@ -1715,9 +1715,56 @@
<artifactId>frontend-maven-plugin</artifactId>
<version>${frontend-maven-plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <version>${protobuf-maven-plugin.version}</version>
+ <extensions>true</extensions>
+ <configuration>
+ <protocArtifact>
+
com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}
+ </protocArtifact>
+ <attachProtoSources>false</attachProtoSources>
+ </configuration>
+ <executions>
+ <execution>
+ <id>src-compile-protoc</id>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>compile</goal>
+ </goals>
+ <configuration>
+
<includeDependenciesInDescriptorSet>false</includeDependenciesInDescriptorSet>
+ <protoSourceRoot>${basedir}/src/main/proto</protoSourceRoot>
+
<outputDirectory>${project.build.directory}/generated-sources/java</outputDirectory>
+ <clearOutputDirectory>false</clearOutputDirectory>
+ </configuration>
+ </execution>
+ <execution>
+ <id>src-compile-test-protoc</id>
+ <phase>generate-test-sources</phase>
+ <goals>
+ <goal>test-compile</goal>
+ </goals>
+ <configuration>
+
<includeDependenciesInDescriptorSet>false</includeDependenciesInDescriptorSet>
+ <protoSourceRoot>${basedir}/src/test/proto</protoSourceRoot>
Review comment:
for "test-compile" goal src proto files will be referred using
"protoTestSourceRoot". Not "protoSourceRoot".
Mentioned here
https://www.xolstice.org/protobuf-maven-plugin/test-compile-mojo.html#protoTestSourceRoot
This is also updated in #1494. Please rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
