steveloughran commented on a change in pull request #1481: HADOOP-16587: Made
auth endpoints configurable for MSI and refresh token flows
URL: https://github.com/apache/hadoop/pull/1481#discussion_r327102701
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -635,4 +641,24 @@ void setWriteBufferSize(int bufferSize) {
void setEnableFlush(boolean enableFlush) {
this.enableFlush = enableFlush;
}
+
+ private String getMsiAuthEndpoint() throws IOException {
+ String authEndpoint = getPasswordString(
+ FS_AZURE_ACCOUNT_OAUTH_MSI_ENDPOINT);
+ if (Utils.isEmpty(authEndpoint)) {
+ authEndpoint =
+ AuthConfigurations.DEFAULT_FS_AZURE_ACCOUNT_OAUTH_MSI_ENDPOINT;
+ }
+ return authEndpoint;
+ }
+
+ private String getRefreshTokenAuthEndpoint() throws IOException {
+ String authEndpoint = getPasswordString(
+ FS_AZURE_ACCOUNT_OAUTH_REFRESH_TOKEN_ENDPOINT);
+ if (Utils.isEmpty(authEndpoint)) {
+ authEndpoint =
+
AuthConfigurations.DEFAULT_FS_AZURE_ACCOUNT_OAUTH_REFRESH_TOKEN_ENDPOINT;
+ }
+ return authEndpoint;
Review comment:
given the empty check is on the trimmed value, should the authEndpoint be
returned trimmed? as currenty a path like " http://something " with a space at
either end will go through here and fail later, possibly with a meaningless
message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
