vinayakumarb commented on a change in pull request #1496: HADOOP-16560. [YARN]
use protobuf-maven-plugin to generat…
URL: https://github.com/apache/hadoop/pull/1496#discussion_r327233382
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml
##########
@@ -154,28 +154,21 @@
</configuration>
</plugin>
<plugin>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-maven-plugins</artifactId>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
<executions>
<execution>
- <id>compile-protoc</id>
- <goals>
- <goal>protoc</goal>
- </goals>
+ <id>src-test-compile-protoc</id>
Review comment:
Before this change, `YarnSecurityTestAMRMTokenProtos` was getting generated
in "target/generated-sources" directory and has been treated as main src. But
ideally it should be part of test only.
This should not be a problem I hope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
