hadoop-yetus commented on a change in pull request #1513: HDDS-2149. Replace
FindBugs with SpotBugs
URL: https://github.com/apache/hadoop/pull/1513#discussion_r327893424
##########
File path: hadoop-ozone/dev-support/checks/findbugs.sh
##########
@@ -16,16 +16,17 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-mvn -B compile -fn findbugs:check -Dfindbugs.failOnError=false -f
pom.ozone.xml
+mvn -B compile spotbugs:spotbugs -f pom.ozone.xml
REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/findbugs"}
mkdir -p "$REPORT_DIR"
REPORT_FILE="$REPORT_DIR/summary.txt"
touch "$REPORT_FILE"
-find hadoop-ozone -name findbugsXml.xml -print0 | xargs -0 -n1
convertXmlToText | tee -a "${REPORT_FILE}"
-find hadoop-hdds -name findbugsXml.xml -print0 | xargs -0 -n1
convertXmlToText | tee -a "${REPORT_FILE}"
+find hadoop-hdds hadoop-ozone -name spotbugsXml.xml -print0 | xargs -0
unionBugs -output ${REPORT_DIR}/summary.xml
+convertXmlToText ${REPORT_DIR}/summary.xml | tee -a "${REPORT_FILE}"
+convertXmlToText -html:fancy-hist.xsl ${REPORT_DIR}/summary.xml
${REPORT_DIR}/summary.html
Review comment:
shellcheck:39: note: Double quote to prevent globbing and word splitting.
[SC2086]
shellcheck:65: note: Double quote to prevent globbing and word splitting.
[SC2086]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
