elek commented on issue #1520: HDDS-2175. Propagate stack trace for OM 
Exceptions to the Client. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1520#issuecomment-534923342
 
 
   Thank you very much to file this issue @supratimdeka. The big question (for 
me) is the type of the exceptions. 
   
   There are two kind of exception: 
   
    * Business exceptions (eg. VolumeNotFound) and 
    * System exceptions (eg. connection refused).
   
   This particular code is about propagating the business exceptions. I am not 
sure if we need to 
   propagate the strack trace there. For example a VOLUME_NOT_FOUND doesn't 
require any exception message to be propagated.
    
   It's enough to propagate the error type and the message. (This is what we 
do.)
   
   In case of a real system exception the stack trace is is propagated with 
Hadoop RPC (inside an RpcException If I remember well... The full stack trace 
is propagated there...)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to