ChenSammi commented on a change in pull request #1469: HDDS-2034. Async RATIS
pipeline creation and destroy through heartbea…
URL: https://github.com/apache/hadoop/pull/1469#discussion_r328408887
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/OneReplicaPipelineSafeModeRule.java
##########
@@ -75,69 +66,59 @@ public OneReplicaPipelineSafeModeRule(String ruleName,
EventQueue eventQueue,
HDDS_SCM_SAFEMODE_ONE_NODE_REPORTED_PIPELINE_PCT +
" value should be >= 0.0 and <= 1.0");
+ // Exclude CLOSED pipeline
int totalPipelineCount =
pipelineManager.getPipelines(HddsProtos.ReplicationType.RATIS,
- HddsProtos.ReplicationFactor.THREE).size();
+ HddsProtos.ReplicationFactor.THREE, Pipeline.PipelineState.OPEN)
+ .size() +
+ pipelineManager.getPipelines(HddsProtos.ReplicationType.RATIS,
+ HddsProtos.ReplicationFactor.THREE,
+ Pipeline.PipelineState.ALLOCATED).size();
Review comment:
Hi @xiaoyuyao , here are two cases,
1. A new cluster, ALLOCATED pipelie numbe is 0 at cluster start up.
2. A running cluster, restart SCM, all the pipelines loaded from DB is
marked as ALLOCATED(SCMPipelineManager#initializePipelineState(), current
logic). So in this case, ALLOCATED state pipeline means OPEN pipeline actually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
