steveloughran commented on issue #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1 URL: https://github.com/apache/hadoop/pull/1523#issuecomment-535461886 I actually quite like the -1, as it says "you need a good explanation". If people are submitting patches without tests, they need good explanations. In contrast, we don't worry so much about checkstyle -which is why we're always fighting a losing battle against adherence to the style rules. 1. I want people to feel uncomfortable when they submit patches without any tests. Having Yetus complaining about this avoids the personal conflict which arises when are people like me after the tests instead. 2. And I like to be confident that those patches which I don't review, come with tests too.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
