anuengineer commented on a change in pull request #1504: HDDS-2068. Make
StorageContainerDatanodeProtocolService message based
URL: https://github.com/apache/hadoop/pull/1504#discussion_r328404623
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -370,6 +349,7 @@ public void stop() {
LOG.error(" datanodeRpcServer stop failed.", ex);
}
IOUtils.cleanupWithLogger(LOG, scm.getScmNodeManager());
+ protocolMessageMetrics.register();
Review comment:
It is a little jarring to see a Register call in the stop section. You might
want to write a comment saying what this function does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
