xiaoyuyao commented on a change in pull request #1505: HDDS-2166. Some RPC
metrics are missing from SCM prometheus endpoint
URL: https://github.com/apache/hadoop/pull/1505#discussion_r328759936
##########
File path:
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/server/TestPrometheusMetricsSink.java
##########
@@ -71,6 +73,50 @@ public void testPublish() throws IOException {
metrics.shutdown();
}
+ @Test
+ public void testPublishWithSameName() throws IOException {
+ //GIVEN
+ MetricsSystem metrics = DefaultMetricsSystem.instance();
+
+ metrics.init("test");
+ PrometheusMetricsSink sink = new PrometheusMetricsSink();
+ metrics.register("Prometheus", "Prometheus", sink);
+ metrics.register("FooBar", "fooBar", (MetricsSource) (collector, all) -> {
+ collector.addRecord("RpcMetrics").add(new MetricsTag(PORT_INFO, "1234"))
+ .addGauge(COUNTER_INFO, 123).endRecord();
+
+ collector.addRecord("RpcMetrics").add(new MetricsTag(
+ PORT_INFO, "2345")).addGauge(COUNTER_INFO, 234).endRecord();
+ });
+
+ metrics.start();
+ metrics.publishMetricsNow();
+
+ ByteArrayOutputStream stream = new ByteArrayOutputStream();
+ OutputStreamWriter writer = new OutputStreamWriter(stream, UTF_8);
+
+ //WHEN
+ sink.writeMetrics(writer);
+ writer.flush();
+
+ //THEN
+ String writtenMetrics = stream.toString(UTF_8.name());
+ System.out.println(writtenMetrics);
Review comment:
NIT: debug message can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
