sidseth commented on issue #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a URL: https://github.com/apache/hadoop/pull/1516#issuecomment-535707344 > Have you thought about how to do an integration test here? I could imagine a custom signer which just forwards to the AWS signer Wasn't planning on adding any integration tests. Most of this can be tested quite easily with unit tests. > and what about collecting metrics on this, e.g. #of signing requests made. We could have another callback under org.apache.hadoop.fs.s3a.S3AInstrumentation which the signers could use to pass this info back The default usage (no custom signers) will not be able to use any instrumentation, and I don't think we want to force a Wrapper Signer just for isntrumentation(may not even be possible given Signers cannot access configs and we would not know the real signer in a wrapper) Instrumentation could be passed as a parameter to SignerInitializer that is being added as part of this patch. I'll defer to you on whether adding the Instrumentation to the interface makes sense. Don't know enough about S3AInstrumentation and usage.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
