snvijaya commented on a change in pull request #1508: HADOOP-16548 : Disable
Flush() over config
URL: https://github.com/apache/hadoop/pull/1508#discussion_r329176688
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -199,7 +202,7 @@ private void maybeThrowLastError() throws IOException {
*/
@Override
public void flush() throws IOException {
- if (supportFlush) {
+ if (!disableOutputStreamFlush) {
Review comment:
Based on how Flush() is already a noop in WASB and ADLS Gen1, the
recommendation was to remove the functional flow. But incase any customer has
taken a dependency on Flush() being part of driver GA version, we expect the
new config to highlight that they need to move to Hflush()/Hsync() specifically
for flush operation and understand the perf impact on continuing to use Flush
API. As supportFlush is almost always expected to be config set as true,
Flush() will be effectively controlled by new config. Will check with you
offline too incase I am missing any point of concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
