bharatviswa504 commented on a change in pull request #1541: HDDS-1146. Adding
container related metrics in SCM.
URL: https://github.com/apache/hadoop/pull/1541#discussion_r329231264
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManager.java
##########
@@ -179,4 +179,12 @@ ContainerInfo getMatchingContainer(long size, String
owner,
*/
ContainerInfo getMatchingContainer(long size, String owner,
Pipeline pipeline, List<ContainerID> excludedContainerIDS);
+
+ /**
+ * Once after report processor handler completes, call this to notify
+ * container manager to increment metrics.
+ * @param isFullReport
+ * @param success
+ */
+ void notifyContainerReportProcessing(boolean isFullReport, boolean success);
Review comment:
From proto, there is no enum. But i see we have TypedEvent
TypedEvent<IncrementalContainerReportFromDatanode>
INCREMENTAL_CONTAINER_REPORT = new TypedEvent<>(
IncrementalContainerReportFromDatanode.class,
"Incremental_Container_Report")
TypedEvent<ContainerReportFromDatanode> CONTAINER_REPORT =
new TypedEvent<>(ContainerReportFromDatanode.class,
"Container_Report");
Do you mean we want to use them instead of boolean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
