avijayanhwx commented on a change in pull request #1541: HDDS-1146. Adding
container related metrics in SCM.
URL: https://github.com/apache/hadoop/pull/1541#discussion_r329256932
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java
##########
@@ -66,16 +67,25 @@ public void onMessage(final
IncrementalContainerReportFromDatanode report,
nodeManager.addContainer(dd, id);
processContainerReplica(dd, replicaProto);
} catch (ContainerNotFoundException e) {
+ success = false;
LOG.warn("Container {} not found!", replicaProto.getContainerID());
} catch (NodeNotFoundException ex) {
+ success = false;
LOG.error("Received ICR from unknown datanode {} {}",
report.getDatanodeDetails(), ex);
} catch (IOException e) {
+ success = false;
LOG.error("Exception while processing ICR for container {}",
replicaProto.getContainerID());
}
}
+ if (success) {
+ getContainerManager().notifyContainerReportProcessing(false, true);
+ } else {
Review comment:
Any reason we are not doing
_getContainerManager().notifyContainerReportProcessing(false, success)_ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
