[ 
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941016#comment-16941016
 ] 

Steve Loughran commented on HADOOP-13363:
-----------------------------------------

We had to make sure that there was no public API which used guava types. And 
for some spark/hive JAR mismatch, I ended up having to abuse hive's shading of 
things so that some other library would be in sync.

If we are passing protobuf types around, either as inputs or outputs. Then we 
cannot shade the artifacts. And so: we cannot update protobuf "transparently".

For Token, if that toProbuf method is considered private, well, we could move 
the operation out into its own class and invoke passing in a Token instance, 
but it is probably a symptom of a bigger problem -protobuf types in public APIs

I think we need a way of identifying what those are.

> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
>                 Key: HADOOP-13363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13363
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
>            Reporter: Anu Engineer
>            Assignee: Vinayakumar B
>            Priority: Major
>              Labels: security
>         Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch, 
> HADOOP-13363.003.patch, HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms.  (See, for 
> example, https://gist.github.com/BennettSmith/7111094 ).  In order for us to 
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is 
> starting to slowly disappear as a standard install-able package for even 
> Linux/x86, we need to either upgrade or self bundle or something else.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to