steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR
failures
URL: https://github.com/apache/hadoop/pull/1115#discussion_r330474645
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java
##########
@@ -61,45 +69,70 @@
* If two subclasses of this class are instantiated in the same JVM, in order,
* they are guaranteed to be isolated.
*
- * History: this is a superclass extracted from
- * {@link AbstractITCommitMRJob} while adding support for testing terasorting.
- *
*/
public abstract class AbstractYarnClusterITest extends AbstractCommitITest {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractYarnClusterITest.class);
- private static final int TEST_FILE_COUNT = 2;
- private static final int SCALE_TEST_FILE_COUNT = 50;
+ private static final int TEST_FILE_COUNT = 1;
+ private static final int SCALE_TEST_FILE_COUNT = 2;
- public static final int SCALE_TEST_KEYS = 1000;
+ public static final int SCALE_TEST_KEYS = 100;
public static final int BASE_TEST_KEYS = 10;
private boolean scaleTest;
- private boolean uniqueFilenames = false;
+ /**
+ * The static cluster binding with the lifecycle of this test; served
+ * through instance-level methods for sharing across methods in the
+ * suite.
+ */
+ @SuppressWarnings("StaticNonFinalField")
+ private static ClusterBinding clusterBinding;
Review comment:
The test suite is not creating and destroying clusters in indivudual methods
AbstractYarnClusterITest
1. stores the binding in a static method
1. Instantiates in the first test case setup encountered; this is designed
to pick up all those command line customisation properties you were missing out
on.
1. And it is destroyed in a static afterclass method
All subclasses of this test get that behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
