goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330670733
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java ########## @@ -77,9 +85,31 @@ boolean removeStorage(DatanodeStorageInfo storage) { setStorageInfo(dnIndex, getStorageInfo(lastNode)); // set the last entry to null setStorageInfo(lastNode, null); + if (storage.getStorageType() == StorageType.PROVIDED + && !hasProvidedStorages()) { Review comment: I see is the other method which goes over each DN, nevermind. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org