bharatviswa504 commented on a change in pull request #1486: HDDS-2158. Fixing
Json Injection Issue in JsonUtils.
URL: https://github.com/apache/hadoop/pull/1486#discussion_r330754661
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/RemoveAclBucketHandler.java
##########
@@ -92,8 +92,9 @@ public Void call() throws Exception {
boolean result = client.getObjectStore().removeAcl(obj,
OzoneAcl.parseAcl(acl));
- System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
- JsonUtils.toJsonString("Acl removed successfully: " + result)));
+ System.out.printf("%s%n", result ? "ACL removed successfully" :
+ "ACL not removed");
Review comment:
From my understanding, addAcl behavior is if acl is added successfully
returns true, it will return false when acl trying to be added already exists.
>
If we are trying to add an already existing ACL, shouldn't we return true?
I think returning true is not right behavior, as it will not be clear
whether add is successful or not. We should have returned with clear message to
end user, what is differenece between true/false.
`But I think that statement also does not convey the message properly. `
Agreed this was existing behavior, if you want to fix in a new Jira I am
okay with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
