goiri commented on a change in pull request #1573: HDFS-14889. Ability to check
if a block has a replica on provided storage.
URL: https://github.com/apache/hadoop/pull/1573#discussion_r331147781
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java
##########
@@ -64,6 +67,28 @@ public void testAddStorage() throws Exception {
Assert.assertEquals(storage, blockInfo.getStorageInfo(0));
}
+ @Test
+ public void testAddProvidedStorage() throws Exception {
+ BlockInfo blockInfo = new BlockInfoContiguous((short) 3);
+
+ DatanodeStorageInfo storage = mock(DatanodeStorageInfo.class);
+ when(storage.getStorageType()).thenReturn(StorageType.PROVIDED);
+ boolean added = blockInfo.addStorage(storage, blockInfo);
+
+ Assert.assertTrue(added);
+ Assert.assertEquals(storage, blockInfo.getStorageInfo(0));
+ Assert.assertTrue(blockInfo.isProvided());
+
Review comment:
What about splitting this test into two with a name that describes what we
are testing in each?
Another option would be to just have a different blockInfo for the second
chunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
