ashvina commented on a change in pull request #1573: HDFS-14889. Ability to
check if a block has a replica on provided storage.
URL: https://github.com/apache/hadoop/pull/1573#discussion_r331167543
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java
##########
@@ -64,6 +67,28 @@ public void testAddStorage() throws Exception {
Assert.assertEquals(storage, blockInfo.getStorageInfo(0));
}
+ @Test
+ public void testAddProvidedStorage() throws Exception {
+ BlockInfo blockInfo = new BlockInfoContiguous((short) 3);
+
+ DatanodeStorageInfo storage = mock(DatanodeStorageInfo.class);
+ when(storage.getStorageType()).thenReturn(StorageType.PROVIDED);
+ boolean added = blockInfo.addStorage(storage, blockInfo);
+
+ Assert.assertTrue(added);
+ Assert.assertEquals(storage, blockInfo.getStorageInfo(0));
+ Assert.assertTrue(blockInfo.isProvided());
+
Review comment:
There exists a test for verifying behavior of add storage, `testAddStorage
`. I had originally modified the original test and added the `isProvided`
check. It seemed a bit confusing and out of place to me. So I added this test
to clearly test both the scenarios. I would prefer this over two split methods.
I can rename the second blockInfo if that adds value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
