avijayanhwx commented on issue #1538: HDDS-1720 : Add ability to configure 
RocksDB logs for Ozone Manager.
URL: https://github.com/apache/hadoop/pull/1538#issuecomment-538060659
 
 
   > Can you please add a test case that proves that RocksDB actually produces 
logs that we can see. There is a log listener class in the Hadoop. You can use 
them, or create a test and then grep for some of the log statements. Otherwise 
the change looks quite good to me.
   
   Thanks for the review @anuengineer . I have added unit test for verifying 
RocksDB logging. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to