adoroszlai commented on a change in pull request #1583: HDDS-2071. Support
filters in ozone insight point
URL: https://github.com/apache/hadoop/pull/1583#discussion_r331207138
##########
File path:
hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/LogSubcommand.java
##########
@@ -86,12 +93,20 @@ public Void call() throws Exception {
return null;
}
+ /**
+ * Stream log from multiple endpoint.
+ *
+ * @param conf Configuration (to find the log endpoints)
+ * @param sources Components to connect to (like scm, om...)
+ * @param relatedLoggers loggers to display
+ * @param filter any additional filter
+ */
private void streamLog(OzoneConfiguration conf, Set<Component> sources,
- List<LoggerSource> relatedLoggers) {
+ List<LoggerSource> relatedLoggers, Function<String, Boolean> filter) {
Review comment:
I'd prefer a `Predicate<String>` for simplicity (and null-safety).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
