adoroszlai commented on issue #1568: HDDS-2225. SCM fails to start in most 
unsecure environments due to leftover secure config
URL: https://github.com/apache/hadoop/pull/1568#issuecomment-538222650
 
 
   @anuengineer Thanks for taking a look at this.
   
   > So now we have removed the mount and gen config?
   
   The new solution only removes the offending container (spark), which is not 
required by the test at all.  Volume mount and config generation for the other 
containers is not changed.
   
   > I am presuming that +1s were given for the earlier solution, but with 
force push I am not able to see the older changes.
   
   Both earlier solution (ff3671022a267d765d7d631cb5b6e57d46ced12d) and new one 
(5caa23a390197d4b2d4dbb738ac850d02378edc0) are visible in the list of commits.  
The second commit just reverts the first attempt.  The force push was needed 
only to rebase on current trunk.  I agree, it makes understanding the 
conversation harder.  I'll try a plain merge next time.
   
   Earlier +1s were for the first solution, while @elek's [latest 
comment](https://github.com/apache/hadoop/pull/1568#issuecomment-537440726) is 
for the second one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to