[
https://issues.apache.org/jira/browse/HADOOP-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945657#comment-16945657
]
Hudson commented on HADOOP-16512:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17491 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17491/])
HADOOP-16512. [hadoop-tools] Fix order of actual and expected expression
(aajisaka: rev 14cd969b6ea1898e9db6eeb9ea5292ec4558a706)
* (edit)
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java
* (edit) hadoop-tools/hadoop-distcp/pom.xml
* (edit)
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyMapper.java
* (edit) hadoop-tools/hadoop-kafka/pom.xml
* (edit)
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestCopyListing.java
* (edit)
hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java
* (edit) hadoop-tools/hadoop-archives/pom.xml
* (edit)
hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
* (edit)
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/util/TestDistCpUtils.java
> [hadoop-tools] Fix order of actual and expected expression in assert
> statements
> -------------------------------------------------------------------------------
>
> Key: HADOOP-16512
> URL: https://issues.apache.org/jira/browse/HADOOP-16512
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: kevin su
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HADOOP-16512.001.patch, HADOOP-16512.002.patch
>
>
> Fix order of actual and expected expression in assert statements which gives
> misleading message when test case fails. Attached file has some of the places
> where it is placed wrongly.
> {code:java}
> [ERROR]
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
> Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the hadoop-tools project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
