ashvina commented on a change in pull request #1480: HDFS-14857. FS operations
fail in HA mode: DataNode fails to connect to NameNode
URL: https://github.com/apache/hadoop/pull/1480#discussion_r332153348
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ConfiguredFailoverProxyProvider.java
##########
@@ -76,13 +81,7 @@ synchronized void incrementProxyIndex() {
@Override
public synchronized void close() throws IOException {
for (ProxyInfo<T> proxy : proxies) {
- if (proxy.proxy != null) {
- if (proxy.proxy instanceof Closeable) {
- ((Closeable)proxy.proxy).close();
- } else {
- RPC.stopProxy(proxy.proxy);
- }
- }
+ stopProxy(proxy.proxy);
Review comment:
The behavior is getting changed here. Earlier `IOException` was thrown in
case of an error. It is changed to `RuntimeException` now. I think this change
is not desired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
