bharatviswa504 commented on a change in pull request #1612: HDDS-2260. Avoid 
evaluation of LOG.trace and LOG.debug statement in the read/write path (HDDS).
URL: https://github.com/apache/hadoop/pull/1612#discussion_r332617757
 
 

 ##########
 File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
 ##########
 @@ -120,9 +120,11 @@ public long putBlock(Container container, BlockData data) 
throws IOException {
       container.updateBlockCommitSequenceId(bcsId);
       // Increment keycount here
       container.getContainerData().incrKeyCount();
-      LOG.debug(
-          "Block " + data.getBlockID() + " successfully committed with bcsId "
-              + bcsId + " chunk size " + data.getChunks().size());
+      if (LOG.isDebugEnabled()) {
+        LOG.debug(
+            "Block " + data.getBlockID() + " successfully committed with bcsId 
"
 
 Review comment:
   Use {}

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to