swagle commented on a change in pull request #1610: HDDS-1868. Ozone pipelines
should be marked as ready only after the leader election is complete.
URL: https://github.com/apache/hadoop/pull/1610#discussion_r333225344
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
##########
@@ -207,6 +222,8 @@ public static Pipeline getFromProtobuf(HddsProtos.Pipeline
pipeline)
.setFactor(pipeline.getFactor())
.setType(pipeline.getType())
.setState(PipelineState.fromProtobuf(pipeline.getState()))
+ .setLeaderId(StringUtils.isNotEmpty(pipeline.getLeaderID()) ?
Review comment:
Does it cover for empty "" case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
