[
https://issues.apache.org/jira/browse/HADOOP-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949408#comment-16949408
]
Szilard Nemeth commented on HADOOP-16580:
-----------------------------------------
Hi [~adam.antal]!
Thanks for the patch! Actually, I'm with [~shuzirra] on this one:
Without your excellent explanation, I wouldn't understand why the method is
called failsWithAccessControlExceptionEightTimes.
As you mentioned: Could you please incorporate your explanation into javadoc,
as much as possible? I don't only mean for the above method, but any other part
of code you feel needs some explanation.
Apart from this, I could give a +1 for this, when you have the javadocs in
place.
Thanks!
> Disable retry of FailoverOnNetworkExceptionRetry in case of
> AccessControlException
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-16580
> URL: https://issues.apache.org/jira/browse/HADOOP-16580
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.3.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: HADOOP-16580.001.patch, HADOOP-16580.002.patch
>
>
> HADOOP-14982 handled the case where a SaslException is thrown. The issue
> still persists, since the exception that is thrown is an
> *AccessControlException* because user has no kerberos credentials.
> My suggestion is that we should add this case as well to
> {{FailoverOnNetworkExceptionRetry}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
