xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager
should send correct ACL type in ACL requests…
URL: https://github.com/apache/hadoop/pull/1528#discussion_r334089125
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1654,28 +1655,28 @@ public boolean checkAccess(OzoneObj ozObject,
RequestContext context)
metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volume, bucket);
try {
validateBucket(volume, bucket);
- OmKeyInfo keyInfo = null;
- try {
- OzoneFileStatus fileStatus = getFileStatus(args);
- keyInfo = fileStatus.getKeyInfo();
- if (keyInfo == null) {
- // the key does not exist, but it is a parent "dir" of some key
- // let access be determined based on volume/bucket/prefix ACL
- if (LOG.isDebugEnabled()) {
- LOG.debug("key:{} is non-existent parent, permit access to
user:{}",
- keyName, context.getClientUgi());
- }
- return true;
- }
- } catch (OMException e) {
- if (e.getResult() == FILE_NOT_FOUND) {
- keyInfo = metadataManager.getOpenKeyTable().get(objectKey);
+ OmKeyInfo keyInfo;
+
+ if (ozObject.getResourceType() == OPEN_KEY) {
Review comment:
what's the difference between OPEN_KEY->CREATE and KEY->CREATE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
