arp7 commented on a change in pull request #1622: HDDS-1228. Chunk Scanner
Checkpoints
URL: https://github.com/apache/hadoop/pull/1622#discussion_r334164946
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -95,14 +97,19 @@ public void runIteration() {
while (!stopping && itr.hasNext()) {
Container c = itr.next();
if (c.shouldScanData()) {
+ ContainerData containerData = c.getContainerData();
+ long containerId = containerData.getContainerID();
try {
+ logScanStart(containerData);
if (!c.scanData(throttler, canceler)) {
metrics.incNumUnHealthyContainers();
- controller.markContainerUnhealthy(
- c.getContainerData().getContainerID());
+ controller.markContainerUnhealthy(containerId);
Review comment:
We should also call `logScanCompleted` and `updateDataScanTimestamp` in the
failure path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
