arp7 commented on a change in pull request #1637: HDDS-2206. Separate handling
for OMException and IOException in the Ozone Manager. Contributed by Supratim
Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334176751
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
##########
@@ -219,7 +244,7 @@ private OMResponse submitRequestDirectlyToOM(OMRequest
request) {
omClientResponse = omClientRequest.validateAndUpdateCache(
ozoneManager, index, ozoneManagerDoubleBuffer::add);
}
- } catch(IOException ex) {
+ } catch(OMException ex) {
Review comment:
I think we don't need this catch block at all, as the caller will do the
right thing via the call to `createErrorResponse`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
