hddong commented on a change in pull request #1614: HADOOP-16615. Add password
check for credential provider
URL: https://github.com/apache/hadoop/pull/1614#discussion_r334237483
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
##########
@@ -293,6 +300,91 @@ public String getUsage() {
}
}
+ private class CheckCommand extends Command {
+ public static final String USAGE = "check <alias> [-value alias-value] " +
+ "[-provider provider-path] [-strict]";
+ public static final String DESC =
+ "The check subcommand check a password for the name\n" +
+ "specified as the <alias> argument within the provider indicated\n" +
+ "through the -provider argument. If -strict is supplied, fail\n" +
+ "immediately if the provider requires a password and none is given.\n"
+
+ "If -value is provided, use that for the value of the credential\n" +
+ "instead of prompting the user.";
+
+ private String alias = null;
+
+ public CheckCommand(String alias) {
Review comment:
@steveloughran a checkstyle error here `public CheckCommand(String alias)
{:5: Redundant 'public' modifier. [RedundantModifier]` , but i think `public`
is need here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
