[ 
https://issues.apache.org/jira/browse/HADOOP-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951864#comment-16951864
 ] 

Adam Antal commented on HADOOP-16510:
-------------------------------------

Cannot reproduce the TestFixKerberosTicketOrder.test failure locally - I 
suppose this is some intermittent issue.
The javac error is still not relevant since the mentioned deprecated method was 
present before the patch and I simply didn't remove it.

> [hadoop-common] Fix order of actual and expected expression in assert 
> statements
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-16510
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16510
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Major
>         Attachments: HADOOP-16510.001.patch, HADOOP-16510.002.patch, 
> HADOOP-16510.003.patch
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up jira for the hadoop-common project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to