steveloughran commented on a change in pull request #1660: HADOOP-16653.
S3Guard DDB overreacts to no tag access
URL: https://github.com/apache/hadoop/pull/1660#discussion_r335517487
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStoreTableManager.java
##########
@@ -387,12 +398,19 @@ protected void verifyVersionCompatibility() throws
IOException {
+ " Table: " + tableName);
}
- LOG.info("Table {} contains no version marker item or tag. " +
- "The table is empty, so the version marker will be added " +
- "as TAG and ITEM.", tableName);
+ if (canReadDdbTags) {
+ LOG.info("Table {} contains no version marker item and tag. " +
+ "The table is empty, so the version marker will be added " +
+ "as TAG and ITEM.", tableName);
+ putVersionMarkerItemToTable();
Review comment:
you've swapped the order. Does this matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
