[
https://issues.apache.org/jira/browse/HADOOP-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953942#comment-16953942
]
Ayush Saxena commented on HADOOP-16466:
---------------------------------------
Thanx [~fengnanli] for the patch.
Overall Looks Good.
I think
{code:java}
121 assertTrue(null != dtSecretManager.retrievePassword(identifier));
362 assertTrue(null != dtSecretManager.retrievePassword(identifier));
{code}
These can be changed to {{assertNotNull()}} and since this is handling only one
class we can change the description accordingly denoting the test class.
> Clean up the Assert usage in tests
> ----------------------------------
>
> Key: HADOOP-16466
> URL: https://issues.apache.org/jira/browse/HADOOP-16466
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Major
> Attachments: HADOOP-16466.001.patch
>
>
> This tickets started with https://issues.apache.org/jira/browse/HDFS-14449
> and we would like to clean up all of the Assert usage in tests to make the
> repo cleaner. This mainly is to make use static imports for the Assert
> functions and use function call without the *Assert.* explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
