lmccay commented on a change in pull request #1664: HADOOP-16658 - S3A
connector does not support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#discussion_r337555745
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/AbstractDelegationTokenBinding.java
##########
@@ -157,17 +159,19 @@ public Text getOwnerText() {
* This will only be called if a new DT is needed, that is: the
* filesystem has been deployed unbonded.
*
- * If {@link #createDelegationToken(Optional, EncryptionSecrets)}
+ * If {@link #createDelegationToken(Optional, EncryptionSecrets, Text)}
* is overridden, this method can be replaced with a stub.
*
* @param policy minimum policy to use, if known.
* @param encryptionSecrets encryption secrets for the token.
+ * @param renewer the principal permitted to renew the token.
* @return the token data to include in the token identifier.
* @throws IOException failure creating the token data.
*/
public abstract AbstractS3ATokenIdentifier createTokenIdentifier(
Optional<RoleModel.Policy> policy,
- EncryptionSecrets encryptionSecrets) throws IOException;
+ EncryptionSecrets encryptionSecrets,
+ Text renewer) throws IOException;
Review comment:
As these are public methods, are you sure that we don't need to preserve the
old signature as well for possible extensions? Does this appear in a public
release yet at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
